-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expand manual in the application data directory to allow users to keep bookmark on the browser #1277
Conversation
❌ Quality checks failed. Please look a Gradle Scan page for details: |
- allow users to make bookmark in the browser Signed-off-by: Hiroshi Miura <[email protected]>
59595c9
to
fc124e1
Compare
Signed-off-by: Hiroshi Miura <[email protected]>
This does not work. The expansion is temporary. The manual is only available when OmegaT is running. We need the manual to be always available, from a specific place, even when OmegaT is not running. We need to have the same situation as 6.0. I don’t understand what you are trying to achieve with temporary expansion of the manual in 6.1. If you want a zip distribution and a location that’s more OS specific, it is OK. But we can’t have a manual whose availability depends on OmegaT running or not. |
Regarding the expansion location, the default configuration folder is a bad choice because users can have OmegaT running with different configuration folders. Which means that the manual will eventually be expanded again, and again, depending on the configuration folder. For macOS, the proper place to put a manual would be: |
I use You suggest |
The equivalent folder on Windows is |
I understand. Here is the suggestion by Apple: https://developer.apple.com/library/archive/qa/qa1170/_index.html For exemple, the BBEdit manual is here: |
application data folder Signed-off-by: Hiroshi Miura <[email protected]>
Implement |
Thank you. The location is better, in my opinion. Now, the bookmark won’t work since the manual disappears when OmegaT is closed. |
Signed-off-by: Hiroshi Miura <[email protected]>
❌ Quality checks failed. Please look a Gradle Scan page for details: |
Is
So I want to propose "local" folder instead of a roaming folder. Any opinions? |
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
I think what matters is that it is not the configuration folder. We should ask the user list. |
This is purely technical question. Why ask user list? |
As you know, the directories
In summary:
That is why I propose |
Currently on Windows platform, |
Because I have no idea what is technically best for Windows. |
But a manual is something you would want to have access to from a portable device so as to read it separately. I don’t understand why MS suggests that should not be the case. |
Its size and the manual data can be reproducible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style can be improved
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Obviously, MS does not care much about size and tries to sell OneDrive sharing device. But I am not in a position to have informed opinions on Windows, so please select what you think it best according to the documentation. |
Exactly. The data is stored in OneDrive. I obtained an explanation how the data sync as follows.
In my old knowledge, Roaming data is stored in Active Directory. I remember a large size data in user profile make performance pressure for enterprise systems. So I said size. |
On a more general note about where to store the documentation.. As far as I can tell from what I see on my work computer, Windows. does not have a standard location for documentation (and probably not even a recommended location). If they do provide a local copy of their documentation, I think most programs use either a subfolder under the folder for the application in If documentation is only stored for the user that installed the program, I would expect to find it under The above is just what I've observed on the computer I use at work. It may not be correct as a generality. On Linux, I believe the preferred location is I would also note, however, that I find very few programs actually provide a local copy of their help or documentation by default, and simply access the website instead. Most software publishers seem to assume all users have a permanent, stable Internet connection these days… Just a few random thoughts. |
Thank you. It seems the best place for OmegaT manual. The folder can be written by administrator or privileged application. The installer should expand manuals into the folder, I think. |
Equivalent on Linux is |
I put an RFE issue around the discussion. It is ready to merge. |
Pull request type
Which ticket is resolved?
https://sourceforge.net/p/omegat/feature-requests/1778/
expand manual in the application data directory to allow users to keep bookmark on the browser
related https://sourceforge.net/p/omegat/mailman/message/59152285/
What does this PR change?
~/Library/Application Support/OmegaT/manual/<version>/<lang>/
instead of temporary folder on macos.%USERPROFILE%\\AppData\\Local\OmegaT
on Windows and~/.local/share/OmegaT/
on Linux.Other information